[jira] [Commented] (SUREFIRE-1681) Don't ignore errors while using maven.test.failure.ignore

["Tibor Digana (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16888842#comment-16888842 ] 

Tibor Digana commented on SUREFIRE-1681:
----------------------------------------

Would you contribute with a fix on GitHub?
Run the build beforehand (takes cca 1 hour) to make sure the fix and tests are alright.
mvn -P run-its install

thx

> Don't ignore errors while using maven.test.failure.ignore
> ---------------------------------------------------------
>
>                 Key: SUREFIRE-1681
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1681
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>    Affects Versions: 3.0.0-M3
>            Reporter: Josef Cacek
>            Priority: Major
>
> This is a follow up for SUREFIRE-1426.
> Surefire should only ignore test failures when SurefirePlugin.testFailureIgnore property is set to true (as the name suggests). Test errors should not be ignored.
> If the forked JVM crashes during the test, then TEST-*.xml report file is not created, so the user will miss the problem when he evaluates test reports afterward (e.g. in Jenkins).
> The code of SurefireHelper.report execution could be improved to verify the error count:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() && result.getErrors() == 0 )
> {
>     log.error( createErrorMessage( reportParameters, result, firstForkException ) );
> }
> {code}
> instead of simply ignoring all problems as it's now:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() )
> {
>     log.error( createErrorMessage( reportParameters, result, firstForkException ) );
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)