You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by sh...@apache.org on 2019/01/24 18:35:05 UTC
samza git commit: Bugfix : Passing localityManager to JobModel when
created from JobModelManager
Repository: samza
Updated Branches:
refs/heads/master 6a1e85eef -> 8f338a8d3
Bugfix : Passing localityManager to JobModel when created from JobModelManager
Samza Standalone required JobModel refactoring, due to which jobModelRef (and localityManager) is set explicitly in JobModelManager: https://github.com/apache/samza/pull/790.
However the JobModel instances with the localityManager (jobModelRef) was not being used when apply() was being called on the JobModelManager by the ClusterBasedJC.
Due to which host-locality was not being read, causing host affinity to break in YARN.
Author: Ray Matharu <rm...@linkedin.com>
Reviewers: Shanthoosh Venkataraman <sp...@usc.edu>
Closes #890 from rmatharu/bugfix-localityManager and squashes the following commits:
bde2d67a [Ray Matharu] removing comment
26150192 [Ray Matharu] Bugfix : Passing localityManager when created in JobModelManager
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/8f338a8d
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/8f338a8d
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/8f338a8d
Branch: refs/heads/master
Commit: 8f338a8d36dd3aebc0b378bee0e86d507967fecc
Parents: 6a1e85e
Author: Ray Matharu <rm...@linkedin.com>
Authored: Thu Jan 24 10:31:42 2019 -0800
Committer: Shanthoosh Venkataraman <sp...@usc.edu>
Committed: Thu Jan 24 10:31:42 2019 -0800
----------------------------------------------------------------------
.../main/scala/org/apache/samza/coordinator/JobModelManager.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/8f338a8d/samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
----------------------------------------------------------------------
diff --git a/samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala b/samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
index e49a61f..0695cd7 100644
--- a/samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
+++ b/samza-core/src/main/scala/org/apache/samza/coordinator/JobModelManager.scala
@@ -81,7 +81,7 @@ object JobModelManager extends Logging {
val server = new HttpServer
server.addServlet("/", new JobServlet(jobModelRef))
- currentJobModelManager = new JobModelManager(jobModel, server, localityManager)
+ currentJobModelManager = new JobModelManager(jobModelRef.get(), server, localityManager)
currentJobModelManager
} finally {
taskAssignmentManager.close()