You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/19 10:32:57 UTC

[GitHub] [tvm] leandron commented on a diff in pull request #11108: [TVMC] Fix error while compile paddle model with tvmc

leandron commented on code in PR #11108:
URL: https://github.com/apache/tvm/pull/11108#discussion_r876891742


##########
tests/python/driver/tvmc/test_command_line.py:
##########
@@ -155,3 +157,41 @@ def test_tvmc_tune_file_check(capsys, invalid_input):
     )
     on_assert_error = f"'tvmc tune' failed to check invalid FILE: {invalid_input}"
     assert captured.err == expected_err, on_assert_error
+
+
+@pytest.fixture
+def paddle_model(paddle_resnet50):
+    # If we can't import "paddle" module, skip testing paddle as the input model.
+    if pytest.importorskip("paddle", reason="'paddle' module not installed"):
+        return paddle_resnet50
+
+
+@pytest.fixture
+def tflite_model(tflite_mobilenet_v1_1_quant):
+    if pytest.importorskip("tflitex", reason="'tflite' module not installed"):

Review Comment:
   ```suggestion
       if pytest.importorskip("tflite", reason="'tflite' module not installed"):
   ```



##########
tests/python/driver/tvmc/test_command_line.py:
##########
@@ -155,3 +157,41 @@ def test_tvmc_tune_file_check(capsys, invalid_input):
     )
     on_assert_error = f"'tvmc tune' failed to check invalid FILE: {invalid_input}"
     assert captured.err == expected_err, on_assert_error
+
+
+@pytest.fixture
+def paddle_model(paddle_resnet50):
+    # If we can't import "paddle" module, skip testing paddle as the input model.
+    if pytest.importorskip("paddle", reason="'paddle' module not installed"):
+        return paddle_resnet50
+
+
+@pytest.fixture
+def tflite_model(tflite_mobilenet_v1_1_quant):
+    if pytest.importorskip("tflitex", reason="'tflite' module not installed"):

Review Comment:
   I think this is being always skipped because we don't have a `tflitex` module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org