You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/02/08 03:14:24 UTC
[GitHub] [openwhisk-runtime-docker] pwplusnick opened a new pull request
#82: Enable multiple platforms to use actionproxy
pwplusnick opened a new pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82
* Add an ability to use action proxy with different platforms
* Add openwhisk platform implementation
* Add knative platform implementation
* Update dockerfile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-docker] pwplusnick commented on a change in pull
request #82: Enable multiple platforms to use actionproxy
Posted by GitBox <gi...@apache.org>.
pwplusnick commented on a change in pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82#discussion_r382833855
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -286,6 +300,18 @@ def complete(response):
def main():
+ platformImpl = None
+ PlatformFactory.addPlatform(PLATFORM_OPENWHISK, OpenWhiskImpl)
+ PlatformFactory.addPlatform(PLATFORM_KNATIVE, KnativeImpl)
Review comment:
I have taken direct use of the Platform factory but left it in as a comment for future committers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-docker] mrutkows commented on a change in pull
request #82: Enable multiple platforms to use actionproxy
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82#discussion_r382273662
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -27,17 +27,26 @@
*/
"""
-import sys
-import os
+import base64
Review comment:
Good effort to make this more "pythonic" and import via proper logical groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-docker] mrutkows commented on a change in pull
request #82: Enable multiple platforms to use actionproxy
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82#discussion_r382835461
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -286,6 +300,18 @@ def complete(response):
def main():
+ platformImpl = None
+ PlatformFactory.addPlatform(PLATFORM_OPENWHISK, OpenWhiskImpl)
+ PlatformFactory.addPlatform(PLATFORM_KNATIVE, KnativeImpl)
Review comment:
@pwplusnick Sounds like a good strategy in case we decide to add support for other platforms and allow change of platform emulation between requests (perhaps useful for reuse/concurrency).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-docker] pwplusnick commented on a change in pull
request #82: Enable multiple platforms to use actionproxy
Posted by GitBox <gi...@apache.org>.
pwplusnick commented on a change in pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82#discussion_r382833855
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -286,6 +300,18 @@ def complete(response):
def main():
+ platformImpl = None
+ PlatformFactory.addPlatform(PLATFORM_OPENWHISK, OpenWhiskImpl)
+ PlatformFactory.addPlatform(PLATFORM_KNATIVE, KnativeImpl)
Review comment:
I have taken out direct use of the Platform factory but left it in as a comment for future committers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-docker] mrutkows merged pull request #82: Enable
multiple platforms to use actionproxy
Posted by GitBox <gi...@apache.org>.
mrutkows merged pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-docker] mrutkows commented on a change in pull
request #82: Enable multiple platforms to use actionproxy
Posted by GitBox <gi...@apache.org>.
mrutkows commented on a change in pull request #82: Enable multiple platforms to use actionproxy
URL: https://github.com/apache/openwhisk-runtime-docker/pull/82#discussion_r382274517
##########
File path: core/actionProxy/actionproxy.py
##########
@@ -286,6 +300,18 @@ def complete(response):
def main():
+ platformImpl = None
+ PlatformFactory.addPlatform(PLATFORM_OPENWHISK, OpenWhiskImpl)
+ PlatformFactory.addPlatform(PLATFORM_KNATIVE, KnativeImpl)
Review comment:
Love the use of the factory pattern, but realistically we are built for either one platform or the other. For perf. sake we should not "addPlatform" for platforms other than the on set in the environment on load. Shaving milliseconds...
Down the road if we support other target platforms or if the proxy can change platform impls. dynamically (on the fly), the factory reg. approach will be appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services