You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by fvaleri <gi...@git.apache.org> on 2016/07/02 14:53:34 UTC
[GitHub] zeppelin pull request #1114: Proxy build - removed Bower note
GitHub user fvaleri opened a pull request:
https://github.com/apache/zeppelin/pull/1114
Proxy build - removed Bower note
### What is this PR for?
Final version of the proxy setup paragraph on main README.
Removed Bower note beacuse it works with the last checkout from master.
### What type of PR is it?
Documentation
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Final setup for building behind a proxy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fvaleri/zeppelin proxy-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1114
----
commit 53e299d36e176e9d769291c06c8ad5c4a5c1f845
Author: fvaleri <fe...@gmail.com>
Date: 2016-07-02T14:43:36Z
Removed Bower note.
Final setup for building behind a proxy.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: Proxy build - removed Bower note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1114
It's very helpful to edit your title with [DOC] prefix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1114: [DOC] Proxy build - removed Bower note
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by fvaleri <gi...@git.apache.org>.
Github user fvaleri commented on the issue:
https://github.com/apache/zeppelin/pull/1114
Sure, reported in PR description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1114
@Leemoonsoo Please review this PR. You were the reviewer of previous PRs. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by fvaleri <gi...@git.apache.org>.
Github user fvaleri commented on the issue:
https://github.com/apache/zeppelin/pull/1114
What about this?
Someone can confirm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1114
The failure is irrelevant. @fvaleri Could you please link the previous work to refer it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by fvaleri <gi...@git.apache.org>.
Github user fvaleri commented on the issue:
https://github.com/apache/zeppelin/pull/1114
@jongyoul ok, thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1114
I'm merging it into master, if there is no further discussions, verification.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by Federico Valeri <fe...@gmail.com>.
Yes, now works fine, but additional reviews are welcome.
Il 02 lug 2016 8:24 PM, "Leemoonsoo" <gi...@git.apache.org> ha scritto:
> Github user Leemoonsoo commented on the issue:
>
> https://github.com/apache/zeppelin/pull/1114
>
> LGTM. If someone behind proxy can provide additional review, that
> would be helpful.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] zeppelin issue #1114: [DOC] Proxy build - removed Bower note
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1114
LGTM. If someone behind proxy can provide additional review, that would be helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---