You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/09/07 01:48:50 UTC
[I] Add regression coverage for the deprecated static mock flag in config [rocketmq-dashboard]
btlqql opened a new issue, #4010:
URL: https://github.com/apache/rocketmq-dashboard/issues/4010
## Problem
web/src/config.ts exports USE_MOCK for backward compatibility, but the existing test only covers API_BASE_URL. The deprecated flag is not protected by a regression test, so it could be accidentally flipped and reintroduce the legacy mock-data code path.
## Expected behavior
- USE_MOCK remains alse for the current Studio runtime.
- A focused Vitest case fails if the flag is changed.
## Scope
Only add regression coverage for web/src/config.test.ts. No runtime code changes.
## Acceptance criteria
- [ ] A Vitest assertion verifies USE_MOCK === false.
- [ ] The targeted test file passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for the deprecated static mock flag in config [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4010:
URL: https://github.com/apache/rocketmq-dashboard/issues/4010#issuecomment-5563995885
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
**Feasibility:** Feasible — straightforward test addition with no runtime code changes.
**Scope:** `web/src/config.test.ts` only.
**Compatibility:** No breaking changes. Pure test coverage addition.
This is a valid request. The `USE_MOCK` flag in `web/src/config.ts` is a deprecated backward-compatibility export that should be guarded by a regression test to prevent accidental re-enablement of the legacy mock-data code path.
**Assessment:**
- Adding a focused Vitest assertion (`expect(USE_MOCK).toBe(false)`) is low-risk and well-scoped.
- This protects against regressions where someone might flip the flag without realizing the downstream impact.
- Acceptance criteria are clear and achievable.
An automated fix proposal (test addition only) will be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for the deprecated static mock flag in config [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4010:
URL: https://github.com/apache/rocketmq-dashboard/issues/4010#issuecomment-6135179978
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for the deprecated static mock flag in config [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4010: Add regression coverage for the deprecated static mock flag in config
URL: https://github.com/apache/rocketmq-dashboard/issues/4010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org