[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20728: [WIP] feature(dashboard): Drill to detail modal

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20728:
URL: https://github.com/apache/superset/pull/20728#discussion_r927756823


##########
superset-frontend/packages/superset-ui-core/src/query/types/Query.ts:
##########
@@ -32,23 +32,30 @@ import { PostProcessingRule } from './PostProcessing';
 import { JsonObject } from '../../connection';
 import { TimeGranularity } from '../../time-format';
 
-export type QueryObjectFilterClause = {
+export type BaseQueryObjectFilterClause = {
   col: QueryFormColumn;
   grain?: TimeGranularity;
   isExtra?: boolean;

Review Comment:
   the grain and isExtra(if the column is a time column and needs grain) are still available to us, please do not change them. .....or we can refactor this part later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org