Re: [PR] Change segment state on HttpLoadQueuePeon from "moving from" to "dropping" atomically (druid)

["FrankChen021 (via GitHub)" <gi...@apache.org>]

FrankChen021 commented on code in PR #18824:
URL: https://github.com/apache/druid/pull/18824#discussion_r3141743203


##########
server/src/main/java/org/apache/druid/server/coordinator/loading/HttpLoadQueuePeon.java:
##########
@@ -410,6 +424,9 @@ private void updateSuccessOrFailureInHolder(SegmentHolder holder, SegmentChangeS
             } else {
               onRequestCompleted(holder, RequestStatus.SUCCESS, status);
             }
+
+            holder.markRequestSucceeded();
+            recentlySucceededActions.add(holder);

Review Comment:
   [P2] Failed requests are retained as recently succeeded
   
   updateSuccessOrFailureInHolder adds every completed holder to recentlySucceededActions even after SegmentChangeStatus.State.FAILED. getSegmentsInQueue then reports a failed load/drop as still pending until timeout when the inventory does not match the successful end state, so the coordinator can suppress retries or project a failed drop/load incorrectly for the whole load timeout. Only successful statuses should enter this reconciliation set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org