You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by willr3 <gi...@git.apache.org> on 2017/01/18 14:18:36 UTC
[GitHub] activemq-artemis pull request #967: pool InVMConnection.write buffers, clone...
GitHub user willr3 opened a pull request:
https://github.com/apache/activemq-artemis/pull/967
pool InVMConnection.write buffers, clone to Unpooled for retention
clone for MessageImpl.decodeFromBuffer and ChannelBufferWrapper.readSlice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/willr3/activemq-artemis 1.5.1-InVMPool
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/967.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #967
----
commit bc7239483af3b8a1207794e452bbc51d6480d53e
Author: Will Reichert <wi...@gmail.com>
Date: 2017-01-04T16:14:16Z
pool InVMConnection.write buffers, clone to Unpooled for MessageImpl.decodeFromBuffer and ChannelBufferWrapper.readSlice
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #967: pool InVMConnection.write buffers, clone to Unp...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/967
Could you provide a bit of context for this PR? Also, please follow the 50/72 commit message format as discussed in the [Artemis Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #967: pool InVMConnection.write buffers, clone...
Posted by willr3 <gi...@git.apache.org>.
Github user willr3 closed the pull request at:
https://github.com/apache/activemq-artemis/pull/967
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #967: pool InVMConnection.write buffers, clone to Unp...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/967
Also, it's best for commits to go to the master branch first and then get cherry-picked onto any other necessary branches unless there's a specific reason not to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #967: pool InVMConnection.write buffers, clone to Unp...
Posted by willr3 <gi...@git.apache.org>.
Github user willr3 commented on the issue:
https://github.com/apache/activemq-artemis/pull/967
I'll rebase a branch onto master, fingers crossed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #967: pool InVMConnection.write buffers, clone to Unp...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/967
@willr3 probably best it to cherry-pick on master. and send it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #967: pool InVMConnection.write buffers, clone to Unp...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/967
@willr3 we have to do it on master first, then to cherry-pick on 1.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #967: pool InVMConnection.write buffers, clone to Unp...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/967
@willr3 I manually placed this into 1.x.. please close this PR? since only you or apache infra can do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---