You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/04/15 07:54:18 UTC

svn commit: r1587432 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java

Author: mattsicker
Date: Tue Apr 15 05:54:18 2014
New Revision: 1587432

URL: http://svn.apache.org/r1587432
Log:
Use Loader.loadSystemClass

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java?rev=1587432&r1=1587431&r2=1587432&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java Tue Apr 15 05:54:18 2014
@@ -21,6 +21,7 @@ import java.lang.reflect.Method;
 import org.apache.logging.log4j.core.LogEvent;
 import org.apache.logging.log4j.core.config.plugins.Plugin;
 import org.apache.logging.log4j.core.config.plugins.PluginFactory;
+import org.apache.logging.log4j.core.helpers.Loader;
 import org.apache.logging.log4j.status.StatusLogger;
 
 /**
@@ -59,16 +60,14 @@ public class OnStartupTriggeringPolicy i
         // The reflection is necessary because without it, Google App Engine
         // will refuse to initialize this class.
         try {
-            // FIXME: Class.forName
-            Class<?> factoryClass = Class.forName("java.lang.management.ManagementFactory");
+            Class<?> factoryClass = Loader.loadSystemClass("java.lang.management.ManagementFactory");
             Method getRuntimeMXBean = factoryClass.getMethod("getRuntimeMXBean");
             Object runtimeMXBean = getRuntimeMXBean.invoke(null);
             
-            // FIXME: Class.forName
-            Class<?> runtimeMXBeanClass = Class.forName("java.lang.management.RuntimeMXBean");
+            Class<?> runtimeMXBeanClass = Loader.loadSystemClass("java.lang.management.RuntimeMXBean");
             Method getStartTime = runtimeMXBeanClass.getMethod("getStartTime");
             Long result = (Long) getStartTime.invoke(runtimeMXBean);
-            
+
             return result.longValue();
         } catch (Throwable t) {
             StatusLogger.getLogger().error("Unable to call ManagementFactory.getRuntimeMXBean().getStartTime(), " //