You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/06/14 20:28:15 UTC

Review Request: SQOOP-1083 Split HBaseImportTest into multiple independent tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11880/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've cut the tests into smaller test cases. I did not add any new functionality.


This addresses bug SQOOP-1083.
    https://issues.apache.org/jira/browse/SQOOP-1083


Diffs
-----

  src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e361d208c0dc9c44e04962ec0ef74ba8dcd1593 
  src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java PRE-CREATION 
  src/test/com/cloudera/sqoop/hbase/HBaseImportNullTest.java PRE-CREATION 
  src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java d411f3ddaa1db5849d180de53c4a8d616d691407 
  src/test/com/cloudera/sqoop/hbase/HBaseImportTypesTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11880/diff/


Testing
-------

All tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-1083 Split HBaseImportTest into multiple independent tests

Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11880/#review21914
-----------------------------------------------------------

Ship it!


Ship It!

- Kathleen Ting


On June 14, 2013, 6:28 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11880/
> -----------------------------------------------------------
> 
> (Updated June 14, 2013, 6:28 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've cut the tests into smaller test cases. I did not add any new functionality.
> 
> 
> This addresses bug SQOOP-1083.
>     https://issues.apache.org/jira/browse/SQOOP-1083
> 
> 
> Diffs
> -----
> 
>   src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e361d208c0dc9c44e04962ec0ef74ba8dcd1593 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java PRE-CREATION 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportNullTest.java PRE-CREATION 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java d411f3ddaa1db5849d180de53c4a8d616d691407 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportTypesTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11880/diff/
> 
> 
> Testing
> -------
> 
> All tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>