You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 18:09:11 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
exceptionfactory opened a new pull request, #6113:
URL: https://github.com/apache/nifi/pull/6113
# Summary
[NIFI-10101](https://issues.apache.org/jira/browse/NIFI-10101) Moves the `nifi-hive-nar` out of the standard `nifi-assembly` binary build to an optional profile named `include-hive`. This approach aligns Hive 1.2 components with other Hive 1.1 and Hive 3 components which are already mapped to the optional `include-hive1_1` and `include-hive3` profiles.
Removing the inclusion of Hive 1.2 components in the default binary build reduces the standard size by 100 MB and also encourages selection of the appropriate version when downloading extension NAR files. All Hive components require the `nifi-hive-services-api-nar`, which will be included when building any of the optional profiles.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6113:
URL: https://github.com/apache/nifi/pull/6113#issuecomment-1155232804
> @exceptionfactory - open question - I'm always wondering if we should add, or not, all such profiles in the automated builds: https://github.com/apache/nifi/blob/main/.github/workflows/ci-workflow.yml#L38
That's a good question @pvillard31! Running a build with optional profiles could place an additional load on standard builds, but it would be helpful to make sure the optional profiles are run on a regular basis. We could create a separate workflow, similar to the system tests, that runs every 24 hours. If you want to create a Jira issue for it, I could take a look at putting together a new GitHub workflow configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
URL: https://github.com/apache/nifi/pull/6113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on PR #6113:
URL: https://github.com/apache/nifi/pull/6113#issuecomment-1155268989
I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on PR #6113:
URL: https://github.com/apache/nifi/pull/6113#issuecomment-1155221883
@exceptionfactory - open question - I'm always wondering if we should add, or not, all such profiles in the automated builds: https://github.com/apache/nifi/blob/main/.github/workflows/ci-workflow.yml#L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6113: NIFI-10101 Move nifi-hive-nar to optional include-hive profile
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6113:
URL: https://github.com/apache/nifi/pull/6113#issuecomment-1155279296
> I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it?
That is correct, most of the profiles are limited to controlling what gets included in the assembly. The components and tests are still built as part of the standard ci-workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org