You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/23 09:37:07 UTC
[GitHub] [superset] cemremengu opened a new pull request #13743: feat: use cross-env when running dev-server
cemremengu opened a new pull request #13743:
URL: https://github.com/apache/superset/pull/13743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
# [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=h1) Report
> Merging [#13743](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=desc) (76e534d) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **increase** coverage by `0.01%`.
> The diff coverage is `77.03%`.
> :exclamation: Current head 76e534d differs from pull request most recent head 30dab62. Consider uploading reports for the commit 30dab62 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13743 +/- ##
==========================================
+ Coverage 77.45% 77.47% +0.01%
==========================================
Files 933 933
Lines 47144 47186 +42
Branches 5848 5872 +24
==========================================
+ Hits 36516 36555 +39
- Misses 10485 10489 +4
+ Partials 143 142 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.53% <77.03%> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `66.19% <ø> (+1.81%)` | :arrow_up: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| [...tasourcePanel/DatasourcePanelDragWrapper/index.tsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvRGF0YXNvdXJjZVBhbmVsRHJhZ1dyYXBwZXIvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `100.00% <ø> (+36.36%)` | :arrow_up: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `78.60% <60.00%> (+0.60%)` | :arrow_up: |
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `78.03% <77.69%> (-9.32%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=footer). Last update [5b79f84...30dab62](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
# [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=h1) Report
> Merging [#13743](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=desc) (6ce0176) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6ce0176 differs from pull request most recent head 30dab62. Consider uploading reports for the commit 30dab62 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13743 +/- ##
==========================================
- Coverage 77.45% 77.36% -0.10%
==========================================
Files 933 933
Lines 47144 47383 +239
Branches 5848 5928 +80
==========================================
+ Hits 36516 36656 +140
- Misses 10485 10584 +99
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.40% <ø> (+0.05%)` | :arrow_up: |
| javascript | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | `53.54% <0.00%> (-33.80%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `77.81% <0.00%> (-0.19%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `65.42% <0.00%> (+1.03%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `73.33% <0.00%> (+9.69%)` | :arrow_up: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `75.00% <0.00%> (+11.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=footer). Last update [5b79f84...30dab62](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
# [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=h1) Report
> Merging [#13743](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=desc) (6ce0176) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **decrease** coverage by `1.39%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6ce0176 differs from pull request most recent head 81ac3f1. Consider uploading reports for the commit 81ac3f1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13743 +/- ##
==========================================
- Coverage 77.45% 76.06% -1.40%
==========================================
Files 933 933
Lines 47144 47143 -1
Branches 5848 5848
==========================================
- Hits 36516 35859 -657
- Misses 10485 11105 +620
- Partials 143 179 +36
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.98% <ø> (-5.37%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| ... and [73 more](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=footer). Last update [5b79f84...81ac3f1](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
etr2460 edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-805311480
Yup, agreed! Let's wait to merge until it's added everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
cemremengu commented on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-805149027
@etr2460 should we add it to other commands like `cover` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-805236268
@cemremengu Yes, let's add it to all commands with inline env vars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
# [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=h1) Report
> Merging [#13743](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=desc) (6ce0176) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 6ce0176 differs from pull request most recent head 81ac3f1. Consider uploading reports for the commit 81ac3f1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13743 +/- ##
=======================================
Coverage 77.45% 77.45%
=======================================
Files 933 933
Lines 47144 47144
Branches 5848 5848
=======================================
Hits 36516 36516
Misses 10485 10485
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.34% <ø> (-0.01%)` | :arrow_down: |
| javascript | `63.47% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=footer). Last update [5b79f84...81ac3f1](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] request-info[bot] commented on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
request-info[bot] commented on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804757616
We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title` or `description` empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-805311480
Yup, agreed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #13743:
URL: https://github.com/apache/superset/pull/13743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13743: feat: use cross-env when running dev-server
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13743:
URL: https://github.com/apache/superset/pull/13743#issuecomment-804772705
# [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=h1) Report
> Merging [#13743](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=desc) (6ce0176) into [master](https://codecov.io/gh/apache/superset/commit/5b79f84e1ba2feab10bc9b96fd786d82418b7b4a?el=desc) (5b79f84) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 6ce0176 differs from pull request most recent head 81ac3f1. Consider uploading reports for the commit 81ac3f1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13743 +/- ##
=======================================
Coverage 77.45% 77.45%
=======================================
Files 933 933
Lines 47144 47144
Branches 5848 5848
=======================================
Hits 36516 36516
Misses 10485 10485
Partials 143 143
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.34% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13743/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.90% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=footer). Last update [5b79f84...81ac3f1](https://codecov.io/gh/apache/superset/pull/13743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org