You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/22 20:35:27 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #136: Let install depend on the target binary

patacongo commented on a change in pull request #136: Let install depend on the target binary
URL: https://github.com/apache/incubator-nuttx-apps/pull/136#discussion_r396137838
 
 

 ##########
 File path: Application.mk
 ##########
 @@ -151,6 +151,7 @@ PROGLIST := $(addprefix $(BINDIR)$(DELIM),$(PROGLIST))
 PROGOBJ := $(MAINOBJ)
 
 $(PROGLIST): $(MAINOBJ)
+	$(Q) mkdir -p $(BINDIR)
 
 Review comment:
   1) mkdir should not be used explicitly.  This is incompatible with Window native builds.  You should define something.
   2) If my recollection is correct, mkdir -p does not work on some Unix platforms, I think macOS.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services