You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2017/11/22 01:09:53 UTC
Review Request 64017: Installer - Select Version page should show
HDP-GPL repo if necessary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64017/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Jason Golieb, and Yusaku Sako.
Bugs: AMBARI-22495
https://issues.apache.org/jira/browse/AMBARI-22495
Repository: ambari
Description
-------
Display HDP-GPL repo field under Repositories in Select Version step of Installer only if user agrees to gpl license agreement
Diffs
-----
ambari-web/app/controllers/installer.js a45ac57
ambari-web/app/controllers/wizard/step8_controller.js 4bedde0
ambari-web/app/mappers/repository_version_mapper.js 90086f2
ambari-web/app/mappers/stack_mapper.js 822d35b
ambari-web/app/models/repository.js 91f0083
ambari-web/app/models/stack_version/repository.js 8bd4323
ambari-web/app/templates/wizard/step1.hbs 485bd5d
ambari-web/test/controllers/installer_test.js 3e1c622
Diff: https://reviews.apache.org/r/64017/diff/1/
Testing
-------
Manually tested and verified.
Ambari-web unit tests pass
30518 passing (27s)
157 pending
Thanks,
Vivek Ratnavel Subramanian
Re: Review Request 64017: Installer - Select Version page should show
HDP-GPL repo if necessary
Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64017/#review191763
-----------------------------------------------------------
Ship it!
Ship It!
- Denys Buzhor
On Nov. 22, 2017, 2:25 a.m., Vivek Ratnavel Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64017/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2017, 2:25 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Jason Golieb, and Yusaku Sako.
>
>
> Bugs: AMBARI-22495
> https://issues.apache.org/jira/browse/AMBARI-22495
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Display HDP-GPL repo field under Repositories in Select Version step of Installer only if user agrees to gpl license agreement
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/installer.js a45ac57
> ambari-web/app/controllers/wizard/step8_controller.js 4bedde0
> ambari-web/app/mappers/repository_version_mapper.js 90086f2
> ambari-web/app/mappers/stack_mapper.js 822d35b
> ambari-web/app/models/repository.js 91f0083
> ambari-web/app/models/stack_version/repository.js 8bd4323
> ambari-web/app/templates/wizard/step1.hbs 485bd5d
> ambari-web/test/controllers/installer_test.js 3e1c622
>
>
> Diff: https://reviews.apache.org/r/64017/diff/2/
>
>
> Testing
> -------
>
> Manually tested and verified.
>
> Ambari-web unit tests pass
> 30518 passing (27s)
> 157 pending
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>
Re: Review Request 64017: Installer - Select Version page should show
HDP-GPL repo if necessary
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64017/
-----------------------------------------------------------
(Updated Nov. 22, 2017, 2:25 a.m.)
Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor, Ishan Bhatt, Jaimin Jetly, Jason Golieb, and Yusaku Sako.
Changes
-------
Sending "tags" data while deploying the cluster.
Bugs: AMBARI-22495
https://issues.apache.org/jira/browse/AMBARI-22495
Repository: ambari
Description
-------
Display HDP-GPL repo field under Repositories in Select Version step of Installer only if user agrees to gpl license agreement
Diffs (updated)
-----
ambari-web/app/controllers/installer.js a45ac57
ambari-web/app/controllers/wizard/step8_controller.js 4bedde0
ambari-web/app/mappers/repository_version_mapper.js 90086f2
ambari-web/app/mappers/stack_mapper.js 822d35b
ambari-web/app/models/repository.js 91f0083
ambari-web/app/models/stack_version/repository.js 8bd4323
ambari-web/app/templates/wizard/step1.hbs 485bd5d
ambari-web/test/controllers/installer_test.js 3e1c622
Diff: https://reviews.apache.org/r/64017/diff/2/
Changes: https://reviews.apache.org/r/64017/diff/1-2/
Testing
-------
Manually tested and verified.
Ambari-web unit tests pass
30518 passing (27s)
157 pending
Thanks,
Vivek Ratnavel Subramanian