[GitHub] [hbase] bharathv commented on a change in pull request #2076: HBASE-24740 Enable journal logging for HBase snapshot operation

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #2076:
URL: https://github.com/apache/hbase/pull/2076#discussion_r455459886



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
##########
@@ -624,14 +623,16 @@ private void takeSnapshotInternal(SnapshotDescription snapshot) throws IOExcepti
     AssignmentManager assignmentMgr = master.getAssignmentManager();
     if (assignmentMgr.getTableStateManager().isTableState(snapshotTable,
         ZooKeeperProtos.Table.State.ENABLED)) {
-      LOG.debug("Table enabled, starting distributed snapshot.");
+      LOG.debug("Table enabled, starting distributed snapshot for "

Review comment:
       branch-1 doesn't support parameterized logging, so wrap with LOG.isDebugEnabled() checks? Saves string construction when debug logging isn't enabled. (multiple places).

##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java
##########
@@ -343,6 +343,13 @@ private void load() throws IOException {
     }
   }
 
+  /**
+   * Sets the status task for monitoring all the subtasks for Snapshot operation
+   */
+  public void setMonitoredTask(MonitoredTask statusTask) {

Review comment:
       Any reason to have a separate setter instead of passing it via create() ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org