You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Carlos Sanchez (JIRA)" <ji...@codehaus.org> on 2007/04/27 20:45:26 UTC
[jira] Created: (MJAR-71) use manifest in classesdir/META-INF if
exists
use manifest in classesdir/META-INF if exists
---------------------------------------------
Key: MJAR-71
URL: http://jira.codehaus.org/browse/MJAR-71
Project: Maven 2.x Jar Plugin
Issue Type: Improvement
Affects Versions: 2.1
Reporter: Carlos Sanchez
Fix For: 2.2
With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>2.1</version>
<configuration>
<archive>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
</archive>
</configuration>
</plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Jerome Lacoste (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116342 ]
Jerome Lacoste commented on MJAR-71:
------------------------------------
Please comment on the approach and the parameters. I can provide documentation later on if the approach seems sane.
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Fix For: 2.2
>
> Attachments: MJAR-71-disabled_by_default.diff, MJAR-71-enabled_by_default.diff
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116438 ]
Olivier Lamy commented on MJAR-71:
----------------------------------
Thanks for patch but I'm not sure adding a new parameter to set the default manifest file is needed.
Because the manifestFile configuration is in the the archive configuration part.
Something with readonly should be better like
{code}
/**
* Path to the default MANIFEST file to use will be use if useDefaultManifestFile is set to true
*
* @parameter expression="${project.build.outputDirectory}/META-INF/MANIFEST.MF"
* @required
* @readonly
*/
private File defaultManifestFile;
/**
* Set to true to enable the use of the defaultManifestFile
*
* @parameter expression="${jar.useDefaultManifestFile}" default-value="false"
*/
private boolean useDefaultManifestFile;
{code}
And I have added a test to not override the manifestFile in the archive configuration if it exists.
Even if the user set useDefaultManifestFile to true.
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Fix For: 2.2
>
> Attachments: MJAR-71-disabled_by_default.diff, MJAR-71-enabled_by_default.diff
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Jerome Lacoste (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Lacoste updated MJAR-71:
-------------------------------
Attachment: MJAR-71-disabled_by_default.diff
Here's a tentative fix for the issue. I've made 2 versions, one where the feature is enabled by default, one disabled by default.
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Fix For: 2.2
>
> Attachments: MJAR-71-disabled_by_default.diff, MJAR-71-enabled_by_default.diff
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116322 ]
Dennis Lundberg commented on MJAR-71:
-------------------------------------
This can potentially break backwards compatibility. We probably need to have a boolean parameter to turn this on, with off being the default behavior. Something like useDefaultManifestFile.
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Fix For: 2.2
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy closed MJAR-71.
----------------------------
Assignee: Olivier Lamy
Resolution: Fixed
committed in rev 603097/603098.
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Assignee: Olivier Lamy
> Fix For: 2.2
>
> Attachments: MJAR-71-disabled_by_default.diff, MJAR-71-enabled_by_default.diff
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Jerome Lacoste (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jerome Lacoste updated MJAR-71:
-------------------------------
Attachment: MJAR-71-enabled_by_default.diff
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Fix For: 2.2
>
> Attachments: MJAR-71-disabled_by_default.diff, MJAR-71-enabled_by_default.diff
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAR-71) use manifest in classesdir/META-INF if
exists
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MJAR-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116613 ]
Dennis Lundberg commented on MJAR-71:
-------------------------------------
Olivier, your example looks like what I had in mind. Thanks!
> use manifest in classesdir/META-INF if exists
> ---------------------------------------------
>
> Key: MJAR-71
> URL: http://jira.codehaus.org/browse/MJAR-71
> Project: Maven 2.x Jar Plugin
> Issue Type: Improvement
> Affects Versions: 2.1
> Reporter: Carlos Sanchez
> Assignee: Olivier Lamy
> Fix For: 2.2
>
> Attachments: MJAR-71-disabled_by_default.diff, MJAR-71-enabled_by_default.diff
>
>
> With 2.1 I need to add this to the pom to use the manifest that it's already in the classes folder, make this the default
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <version>2.1</version>
> <configuration>
> <archive>
> <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
> </archive>
> </configuration>
> </plugin>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira