You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by wohali <gi...@git.apache.org> on 2017/03/17 23:12:53 UTC

[GitHub] couchdb pull request #456: Count JS test pass/fails; return proper exit code

GitHub user wohali opened a pull request:

    https://github.com/apache/couchdb/pull/456

    Count JS test pass/fails; return proper exit code

    Currently `test/javascript/run` always returns an exit code of `0`,
    regardless of whether any tests fail or not. This makes any sort of
    automated testing that expects to inspect the results of the run
    invalid.
    
    `make javascript` should now properly fail if any of the JS tests fail.
    It also prints a numerical summary of passed/failed tests, similar to
    the eunit results.
    
    Fixes COUCHDB-3328


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wohali/couchdb 3328-fix-js-test-runner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #456
    
----
commit fe16873de170f08beae90116fc5e0126eb22cf43
Author: Joan Touzet <wo...@apache.org>
Date:   2017-03-17T23:08:33Z

    Count JS test pass/fails; return proper exit code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request #456: Count JS test pass/fails; return proper exit code

Posted by wohali <gi...@git.apache.org>.

Github user wohali closed the pull request at:

    https://github.com/apache/couchdb/pull/456


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb issue #456: Count JS test pass/fails; return proper exit code

Posted by michellephung <gi...@git.apache.org>.

Github user michellephung commented on the issue:

    https://github.com/apache/couchdb/pull/456
  
    +1 \o/ passing tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb issue #456: Count JS test pass/fails; return proper exit code

Posted by wohali <gi...@git.apache.org>.

Github user wohali commented on the issue:

    https://github.com/apache/couchdb/pull/456
  
    Ironically, the failed Travis CI run shows exactly what I mean. I don't know if the failing JS test (`test/javascript/tests/replication.js`) fails only on R16B03 because we have a bug there, or because the test case is flaky. This demands further investigation - _after_ we merge this change. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---