[jira] [Work logged] (HDFS-16672) Fix lease interval comparison in BlockReportLeaseManager

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16672?focusedWorklogId=793256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793256 ]

ASF GitHub Bot logged work on HDFS-16672:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jul/22 13:50
            Start Date: 20/Jul/22 13:50
    Worklog Time Spent: 10m 
      Work Description: cxzl25 opened a new pull request, #4598:
URL: https://github.com/apache/hadoop/pull/4598

   ### Description of PR
   
   monotonicNowMs is generated by System.nanoTime(), direct comparison is not recommended.
   
   org.apache.hadoop.hdfs.server.blockmanagement.BlockReportLeaseManager#pruneIfExpired
   ```java
   if (monotonicNowMs < node.leaseTimeMs + leaseExpiryMs) {
     return false;
   } 
   ```
   
   ### How was this patch tested?
   exist UT
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 793256)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix lease interval comparison in BlockReportLeaseManager
> --------------------------------------------------------
>
>                 Key: HDFS-16672
>                 URL: https://issues.apache.org/jira/browse/HDFS-16672
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: dzcxzl
>            Assignee: dzcxzl
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> org.apache.hadoop.hdfs.server.blockmanagement.BlockReportLeaseManager#pruneIfExpired
> {code:java}
> if (monotonicNowMs < node.leaseTimeMs + leaseExpiryMs) {
>   return false;
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org