You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "nielm (via GitHub)" <gi...@apache.org> on 2023/02/07 12:14:01 UTC

[GitHub] [beam] nielm commented on pull request #25236: SpannerIO: parameterizing partitionQuery timeout

nielm commented on PR #25236:
URL: https://github.com/apache/beam/pull/25236#issuecomment-1420676441

   Changes LGTM. 
   
   Suggestion: set the new timeouts by default to a (sensible) larger value in SpannerConfig, so that for most users, it will 'just work(TM)' without them needing to choose a value.
   
   I am not sure what a sensible larger value should be - maybe check with @rbrtwng


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org