You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/02 10:06:32 UTC

[GitHub] janpio commented on a change in pull request #450: fix issue #447

janpio commented on a change in pull request #450: fix issue #447
URL: https://github.com/apache/cordova-ios/pull/450#discussion_r230323078
 
 

 ##########
 File path: CordovaLib/Classes/Private/Plugins/CDVUIWebViewEngine/CDVUIWebViewDelegate.m
 ##########
 @@ -329,9 +329,14 @@ - (void)webViewDidFinishLoad:(UIWebView*)webView
             break;
 
         case STATE_WAITING_FOR_LOAD_FINISH:
-            if (_loadCount == 1) {
+            // fix call loadRequest multiple times just callback webViewDidFinishLoad once time in iOS 12
+            if (@available(iOS 12.0, *)) {
 
 Review comment:
   What exactly does this line do? 
   Does it check for "iOS 12.0"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org