[GitHub] eolivelli commented on a change in pull request #1141: Replace DoubleByteBuf with ByteBufList

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1141: Replace DoubleByteBuf with ByteBufList
URL: https://github.com/apache/bookkeeper/pull/1141#discussion_r167451507
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
 ##########
 @@ -302,6 +303,9 @@ protected void initChannel(SocketChannel ch) throws Exception {
                         new BookieSideConnectionPeerContextHandler();
                     ChannelPipeline pipeline = ch.pipeline();
 
+                    // For ByteBufList, skip the usual LengthFieldPrepender and have the encoder itself to add it
+                    pipeline.addLast("bytebufList", ByteBufList.ENCODER_WITH_SIZE);
 
 Review comment:
   If I understand correctly, we are not changing the structure on the wire, it is 100% compatible with old clients, can you confirm @merlimat ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services