You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/08 08:59:41 UTC

[kudu-CR] NOT FOR REVIEW - Make DeltaStore::CheckRowDeleted() return an enum

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4929

to look at the new patch set (#4).

Change subject: NOT FOR REVIEW - Make DeltaStore::CheckRowDeleted() return an enum
......................................................................

NOT FOR REVIEW - Make DeltaStore::CheckRowDeleted() return an enum

This makes it so that CheckRowDeleted() returns an enum instead of
just setting a bool. The new enum allows to stop looking for a delete
delta if we find an update for a row.

This also adds a new visitor to DeltaFileIterator to set the new
enum and simplifies this path, which was overly complex and branchy.
For instance it continuouly checked the validity of the redo regarding
the snapshot, which is not needed since we use an "include all mutations"
snapshhot in this case.

WIP This likely needs a simple test that asserts we stop looking when we
find an update.

Change-Id: Ia5680c0c719cc7d367ea870b2ccf61b81e5fb309
---
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
6 files changed, 109 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/4929/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5680c0c719cc7d367ea870b2ccf61b81e5fb309
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot