You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2017/09/20 00:35:19 UTC
[3/4] hbase git commit: HBASE-18478 Allow users to remove
RegionFinder from LoadBalancer calculations if no locality possible
HBASE-18478 Allow users to remove RegionFinder from LoadBalancer calculations if no locality possible
This provides significant cluster start time reduction for FileSystems which do not surface locality (S3).
Signed-off-by: Andrew Purtell <ap...@apache.org>
Conflicts:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/cfbbcf5c
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/cfbbcf5c
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/cfbbcf5c
Branch: refs/heads/branch-1.4
Commit: cfbbcf5c14f1a5d5d473b390e21d50b88ccaabc4
Parents: d4aa718
Author: Zach York <zy...@amazon.com>
Authored: Thu Jun 22 14:12:49 2017 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Tue Sep 19 16:31:11 2017 -0700
----------------------------------------------------------------------
.../hbase/master/balancer/BaseLoadBalancer.java | 29 ++++++++++++++++----
1 file changed, 23 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/cfbbcf5c/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
index f96f0eb..97a4cb1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
@@ -39,6 +39,7 @@ import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.ClusterStatus;
+import org.apache.hadoop.hbase.HBaseConfiguration;
import org.apache.hadoop.hbase.HBaseIOException;
import org.apache.hadoop.hbase.HDFSBlocksDistribution;
import org.apache.hadoop.hbase.HRegionInfo;
@@ -71,7 +72,8 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
private static final List<HRegionInfo> EMPTY_REGION_LIST = new ArrayList<HRegionInfo>(0);
- protected final RegionLocationFinder regionFinder = new RegionLocationFinder();
+ protected RegionLocationFinder regionFinder;
+ protected boolean useRegionFinder;
private static class DefaultRackManager extends RackManager {
@Override
@@ -85,6 +87,7 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
*/
protected BaseLoadBalancer() {
metricsBalancer = new MetricsBalancer();
+ createRegionFinder();
}
/**
@@ -93,6 +96,14 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
*/
protected BaseLoadBalancer(MetricsBalancer metricsBalancer) {
this.metricsBalancer = (metricsBalancer != null) ? metricsBalancer : new MetricsBalancer();
+ createRegionFinder();
+ }
+
+ private void createRegionFinder() {
+ useRegionFinder = config.getBoolean("hbase.master.balancer.uselocality", true);
+ if (useRegionFinder) {
+ regionFinder = new RegionLocationFinder();
+ }
}
/**
@@ -1085,7 +1096,7 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
// slop for regions
protected float slop;
- protected Configuration config;
+ protected Configuration config = HBaseConfiguration.create();
protected RackManager rackManager;
private static final Random RANDOM = new Random(System.currentTimeMillis());
private static final Log LOG = LogFactory.getLog(BaseLoadBalancer.class);
@@ -1145,7 +1156,9 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
Collections.addAll(tablesOnMaster, tables);
}
this.rackManager = new RackManager(getConf());
- regionFinder.setConf(conf);
+ if (useRegionFinder) {
+ regionFinder.setConf(conf);
+ }
}
protected void setSlop(Configuration conf) {
@@ -1240,14 +1253,18 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
@Override
public synchronized void setClusterStatus(ClusterStatus st) {
this.clusterStatus = st;
- regionFinder.setClusterStatus(st);
+ if (useRegionFinder) {
+ regionFinder.setClusterStatus(st);
+ }
}
@Override
public void setMasterServices(MasterServices masterServices) {
masterServerName = masterServices.getServerName();
this.services = masterServices;
- this.regionFinder.setServices(masterServices);
+ if (useRegionFinder) {
+ this.regionFinder.setServices(masterServices);
+ }
}
public void setRackManager(RackManager rackManager) {
@@ -1398,7 +1415,7 @@ public abstract class BaseLoadBalancer implements LoadBalancer {
protected Cluster createCluster(List<ServerName> servers,
Collection<HRegionInfo> regions, boolean forceRefresh) {
- if (forceRefresh == true) {
+ if (forceRefresh && useRegionFinder) {
regionFinder.refreshAndWait(regions);
}
// Get the snapshot of the current assignments for the regions in question, and then create