You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/23 06:24:30 UTC
[GitHub] [incubator-nuttx-apps] yamt opened a new pull request, #1170: webclient: implement basic proxy
yamt opened a new pull request, #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170
## Summary
webclient: implement basic proxy
## Impact
## Testing
a ported version tested on macOS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1170: webclient: implement basic proxy
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879147230
##########
netutils/webclient/webclient.c:
##########
@@ -182,15 +182,21 @@ struct conn_s
#define WGET_FLAG_GOT_CONTENT_LENGTH 1U
#define WGET_FLAG_CHUNKED 2U
+struct wget_target_s
+ {
+ char scheme[sizeof("https") + 1];
+ char hostname[CONFIG_WEBCLIENT_MAXHOSTNAME];
+ char filename[CONFIG_WEBCLIENT_MAXFILENAME];
+ uint16_t port; /* The port number to use in the connection */
+ };
Review Comment:
seems like +1 is not needed. I will add checking this to my TODO list :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1170: webclient: implement basic proxy
Posted by GitBox <gi...@apache.org>.
yamt commented on code in PR #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879144144
##########
netutils/webclient/webclient.c:
##########
@@ -182,15 +182,21 @@ struct conn_s
#define WGET_FLAG_GOT_CONTENT_LENGTH 1U
#define WGET_FLAG_CHUNKED 2U
+struct wget_target_s
+ {
+ char scheme[sizeof("https") + 1];
+ char hostname[CONFIG_WEBCLIENT_MAXHOSTNAME];
+ char filename[CONFIG_WEBCLIENT_MAXFILENAME];
+ uint16_t port; /* The port number to use in the connection */
+ };
Review Comment:
done (indentation fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1170: webclient: implement basic proxy
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879126090
##########
netutils/webclient/webclient.c:
##########
@@ -1300,9 +1358,21 @@ int webclient_perform(FAR struct webclient_context *ctx)
{
/* Get the server address from the host name */
+ struct wget_target_s *target;
Review Comment:
```suggestion
FAR struct wget_target_s *target;
```
##########
netutils/webclient/webclient.c:
##########
@@ -182,15 +182,21 @@ struct conn_s
#define WGET_FLAG_GOT_CONTENT_LENGTH 1U
#define WGET_FLAG_CHUNKED 2U
+struct wget_target_s
+ {
+ char scheme[sizeof("https") + 1];
+ char hostname[CONFIG_WEBCLIENT_MAXHOSTNAME];
+ char filename[CONFIG_WEBCLIENT_MAXFILENAME];
+ uint16_t port; /* The port number to use in the connection */
+ };
Review Comment:
```suggestion
{
char scheme[sizeof("https") + 1];
char hostname[CONFIG_WEBCLIENT_MAXHOSTNAME];
char filename[CONFIG_WEBCLIENT_MAXFILENAME];
uint16_t port; /* The port number to use in the connection */
};
```
BTW, do you know why `scheme` is `sizeof("https") + 1` and not `sizeof("https")`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1170: webclient: implement basic proxy
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1170: webclient: implement basic proxy
Posted by GitBox <gi...@apache.org>.
yamt commented on code in PR #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879140655
##########
netutils/webclient/webclient.c:
##########
@@ -182,15 +182,21 @@ struct conn_s
#define WGET_FLAG_GOT_CONTENT_LENGTH 1U
#define WGET_FLAG_CHUNKED 2U
+struct wget_target_s
+ {
+ char scheme[sizeof("https") + 1];
+ char hostname[CONFIG_WEBCLIENT_MAXHOSTNAME];
+ char filename[CONFIG_WEBCLIENT_MAXFILENAME];
+ uint16_t port; /* The port number to use in the connection */
+ };
Review Comment:
> BTW, do you know why scheme is sizeof("https") + 1 and not sizeof("https")?
i don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1170: webclient: implement basic proxy
Posted by GitBox <gi...@apache.org>.
yamt commented on code in PR #1170:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879143983
##########
netutils/webclient/webclient.c:
##########
@@ -1300,9 +1358,21 @@ int webclient_perform(FAR struct webclient_context *ctx)
{
/* Get the server address from the host name */
+ struct wget_target_s *target;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org