You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "mkleen (via GitHub)" <gi...@apache.org> on 2026/07/10 08:15:40 UTC

[PR] feat: Support List type in approx_distinct [datafusion]

mkleen opened a new pull request, #23443:
URL: https://github.com/apache/datafusion/pull/23443

   ## Which issue does this PR close?
   
   - Relates to https://github.com/apache/datafusion/issues/22989 but does not close it. More types are coming.
   
   
   ## Rationale for this change
   
   - Support the `List` type for `approx_distinct`
   - The Arrow type `List` can be directly supported for `HLLAccumulator` and `HllGroupsAccumulator`
   
   ## What changes are included in this PR?
   
   - Enable `HLLAccumulator` and `HllGroupsAccumulator` to support `List`
   - Tests for the non-grouped and grouped path as part of `aggregate.slt` 
   
   ## Are these changes tested?
   
   Yes
   
   ## Are there any user-facing changes?
   
   Yes, `approx_distinct` supports now `List` but no breaking changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] feat: Support List/ListView types in approx_distinct [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #23443:
URL: https://github.com/apache/datafusion/pull/23443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] feat: Support List/ListView types in approx_distinct [datafusion]

Posted by "mkleen (via GitHub)" <gi...@apache.org>.
mkleen commented on PR #23443:
URL: https://github.com/apache/datafusion/pull/23443#issuecomment-4943627046

   Thanks for the review @Jefffrey @nuno-faria


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] feat: Support List types in approx_distinct [datafusion]

Posted by "mkleen (via GitHub)" <gi...@apache.org>.
mkleen commented on PR #23443:
URL: https://github.com/apache/datafusion/pull/23443#issuecomment-4943110455

   > probably could include largelist + fixedsizelist (maybe even the view variants) in this PR
   
   Yes, good idea. I added them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] feat: Support List/ListView types in approx_distinct [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #23443:
URL: https://github.com/apache/datafusion/pull/23443#issuecomment-4949523875

   thanks @mkleen & @nuno-faria 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org