You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/26 06:01:23 UTC
[GitHub] [netbeans] jtulach commented on a change in pull request #2831: [NETBEANS-5503] Update JUnit from 4.13.1 to 4.13.2
jtulach commented on a change in pull request #2831:
URL: https://github.com/apache/netbeans/pull/2831#discussion_r602034459
##########
File path: platform/libs.junit4/nbproject/project.xml
##########
@@ -26,24 +26,45 @@
<code-name-base>org.netbeans.libs.junit4</code-name-base>
<module-dependencies/>
<public-packages>
+ <package>org.hamcrest</package>
+ <package>org.hamcrest.core</package>
+ <package>org.hamcrest.internal</package>
<package>junit.extensions</package>
<package>junit.framework</package>
<package>junit.runner</package>
<package>junit.textui</package>
- <package>org.hamcrest</package>
- <package>org.hamcrest.core</package>
<package>org.junit</package>
+ <package>org.junit.experimental</package>
+ <package>org.junit.experimental.categories</package>
+ <package>org.junit.experimental.max</package>
+ <package>org.junit.experimental.results</package>
+ <package>org.junit.experimental.runners</package>
+ <package>org.junit.experimental.theories</package>
+ <package>org.junit.experimental.theories.internal</package>
+ <package>org.junit.experimental.theories.suppliers</package>
+ <package>org.junit.function</package>
+ <package>org.junit.internal</package>
Review comment:
Why do you think the module should expose `internal` packages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists