You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/23 15:54:00 UTC

[jira] [Commented] (ARTEMIS-1415) Coverity: Resource leak on an exceptional path in JMSBridgeImpl.java

    [ https://issues.apache.org/jira/browse/ARTEMIS-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335955#comment-16335955 ] 

ASF GitHub Bot commented on ARTEMIS-1415:
-----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1809

    ARTEMIS-1415 potential JMS bridge conn leak

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1415

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1809.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1809
    
----
commit 591ccc717056d23d47d4e461961636d46e7d2f60
Author: Justin Bertram <jb...@...>
Date:   2018-01-23T15:40:29Z

    ARTEMIS-1415 potential JMS bridge conn leak

----


> Coverity: Resource leak on an exceptional path in JMSBridgeImpl.java
> --------------------------------------------------------------------
>
>                 Key: ARTEMIS-1415
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1415
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Jiri Daněk
>            Assignee: Justin Bertram
>            Priority: Trivial
>
> {noformat}
>     	11. Condition clientID != null, taking true branch.
>  995      if (clientID != null) {
>     	CID 1409381: Resource leak on an exceptional path (RESOURCE_LEAK) [select issue]
>     	12. noescape: Resource conn is not closed or saved in setClientID. (The virtual call resolves to org.apache.activemq.artemis.jms.client.ActiveMQConnection.setClientID.) [show details]
>     	13. throw_uncaught: Throwing javax.jms.IllegalStateException from call to setClientID; exiting method with uncaught exception. (The virtual call resolves to org.apache.activemq.artemis.jms.client.ActiveMQConnection.setClientID.) [show details]
>     	
> CID 1409470 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK)
> 14. leaked_resource: Variable conn going out of scope leaks the resource it refers to.
>  996         conn.setClientID(clientID);
>  997      }
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)