You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by "Ivan Fedotov (JIRA)" <ji...@apache.org> on 2018/07/23 08:48:00 UTC

[jira] [Created] (IGNITE-9051) Remove unnecessary ssh tests

Ivan Fedotov created IGNITE-9051:
------------------------------------

             Summary: Remove unnecessary ssh tests
                 Key: IGNITE-9051
                 URL: https://issues.apache.org/jira/browse/IGNITE-9051
             Project: Ignite
          Issue Type: Test
            Reporter: Ivan Fedotov
            Assignee: Ivan Fedotov


Now in IgniteProjectionStartStopRestartSelfTest there are two unnecessary tests [1], [2] that duplicate other tests. Its duplicate testStopNodesByIds and testRestartNodesByIds respectively because order of ids is not important: if we go deeper in ignite.cluster().stopNodes() method, we can see that in ClusterIgniteImpl [3] all nodes id will be collected in HashSet in forNodesIds method [4]. 

So testStopNodesByIdsC and testRestartNodesByIdsC should be removed.

[1][https://github.com/apache/ignite/blob/master/modules/ssh/src/test/java/org/apache/ignite/internal/IgniteProjectionStartStopRestartSelfTest.java#L701]

[2][https://github.com/apache/ignite/blob/master/modules/ssh/src/test/java/org/apache/ignite/internal/IgniteProjectionStartStopRestartSelfTest.java#L917]

[3][https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java#L250]

[4][https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/cluster/ClusterGroupAdapter.java#L454]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)