You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2015/03/06 21:19:15 UTC
Re: Review Request 31232: OOZIE-2146 add SLA bulk API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31232/#review75534
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/31232/#comment122673>

    If one of jobId, parentId, bundle, nominal_time filters is not specified throw an error asking to specify them.



core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/31232/#comment122704>

    Do debug logging of the constructed query.



core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/31232/#comment122675>

    Can't we use the eventProcessed bit? Query will be simpler



core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/31232/#comment122701>

    CURRENT_TIMESTAMP - Isn't this database specific? We should probably add it as query param



core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java
<https://reviews.apache.org/r/31232/#comment122702>

    Can directly put -1 here. Also expectedDuration != -1 is enough.



core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java
<https://reviews.apache.org/r/31232/#comment122677>

    Let us just do .* instead of Services.get().getSystemId(). If that changes older bundles will not be matched



core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java
<https://reviews.apache.org/r/31232/#comment122679>

    Get rid of the bulk and return all the new fields everytime.



core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java
<https://reviews.apache.org/r/31232/#comment122680>

    ?



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122682>

    Remove this line



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122683>

    Bundle Job ID or Bundle App Name. Fetches SLA information for actions of all coordinators in that bundle.



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122690>

    with comma separation. When multiple statuses are specified, it is considered as OR.



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122684>

    coordiantor -> coordinator



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122685>

    Remove this example and just add new fields to old examples.
    
    If you are keeping it change title to "All Coordinator actions in a Bundle"



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122688>

    Should be number



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122689>

    Remove this line. The filters should apply in all cases.



docs/src/site/twiki/DG_SLAMonitoring.twiki
<https://reviews.apache.org/r/31232/#comment122686>

    Return negative value even for met.


- Rohini Palaniswamy


On Feb. 25, 2015, 7:44 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31232/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 7:44 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-2146
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/oozie/client/OozieClient.java 5de25cc 
>   client/src/main/java/org/apache/oozie/client/rest/JsonTags.java 1022dd7 
>   core/src/main/java/org/apache/oozie/executor/jpa/sla/SLASummaryGetForFilterJPAExecutor.java b55cda3 
>   core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 57170e1 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java a88dcf6 
>   core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 48193c7 
>   core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 1886f48 
>   docs/src/site/twiki/DG_SLAMonitoring.twiki 1413945 
> 
> Diff: https://reviews.apache.org/r/31232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>