[jira] [Commented] (LUCENE-5961) FunctionValues.exist(int) isn't returning false in cases where it should for many "math" based value sources

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174099#comment-14174099 ] 

ASF subversion and git services commented on LUCENE-5961:
---------------------------------------------------------

Commit 1632414 from hossman@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1632414 ]

LUCENE-5961: Fix the exists() method for FunctionValues returned by many ValueSoures to behave properly when wrapping other ValueSources which do not exist for the specified document

> FunctionValues.exist(int) isn't returning false in cases where it should for many "math" based value sources
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5961
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5961
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: LUCENE-5961.patch, LUCENE-5961.patch, LUCENE-5961.patch
>
>
> The FunctionValues class contains an exist(int doc) method with a default implementation that returns true - field based DocValues override this method as appropriate, but most of the "function" based subclasses in the code (typically anonymous subclasses of "FloatDocValues") don't override this method when wrapping other ValueSources.
> So for example: the FunctionValues returned by ProductFloatFunction.getValues() will say that a value exists for any doc, even if that ProductFloatFunction wraps two FloatFieldSources that don't exist for any docs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org