[GitHub] [incubator-doris] morningman commented on a change in pull request #5717: add license to file header and fix Notice file

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5717:
URL: https://github.com/apache/incubator-doris/pull/5717#discussion_r621746374



##########
File path: NOTICE.txt
##########
@@ -7,20 +7,59 @@ The Apache Software Foundation (http://www.apache.org/).
 Based on source code originally developed by
 Baidu (http://www.baidu.com/).
 
-This product includes software developed by the LevelDB.
-Copyright (c) 2011 The LevelDB Authors. All rights reserved.
+--------------------------------------------------------------------------------
 
-This product includes software developed by CPython for searching string function.
-(https://github.com/python/cpython)
+This product includes code from Apache commons-lang, which includes the following in
+its NOTICE file:
 
-This product includes software developed by Chromium.
-Copyright (c) 2011 The Chromium Authors. All rights reserved.
+  Apache commons-lang
+  Copyright 2001-2020 The Apache Software Foundation
 
-This product includes software developed by Austin Appleby for MurmurHash3.
-The author hereby disclaims copyright to this source code.
+  This product includes software developed at
+  The Apache Software Foundation (http://www.apache.org/).

Review comment:
       I think there is no need to put `Apache commons-lang`' NOTICE file here, because it is a Apache software and there is no other special statement in its NOTICE.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org