You are viewing a plain text version of this content. The canonical link for it is here.

Posted to cvs@httpd.apache.org by ji...@apache.org on 2009/09/03 18:02:18 UTC

svn commit: r811009 - /httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c

Author: jim
Date: Thu Sep  3 16:02:18 2009
New Revision: 811009

URL: http://svn.apache.org/viewvc?rev=811009&view=rev
Log:
An error detect question in comments

Modified:
    httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c

Modified: httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c?rev=811009&r1=811008&r2=811009&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c (original)
+++ httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c Thu Sep  3 16:02:18 2009
@@ -153,6 +153,7 @@
     apr_file_close(fp);
 }
 
+/* should be apr_status_t really */
 static void restore_slotmem(void *ptr, const char *name, apr_size_t size,
                             apr_pool_t *pool)
 {
@@ -318,6 +319,10 @@
         memcpy(ptr, &desc, sizeof(desc));
         ptr = ptr + sizeof(desc);
         memset(ptr, 0, dsize);
+        /*
+         * TODO: Error check the below... What error makes
+         * sense if the restore fails? Any?
+         */
         if (type & AP_SLOTMEM_TYPE_PERSIST)
             restore_slotmem(ptr, fname, dsize, pool);
     }