You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 04:42:14 UTC

[GitHub] [phoenix] stoty commented on pull request #973: PHOENIX-6211 Paged scan filters

stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-729402100


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   4m 14s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 1 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  13m 11s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 58s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 14s |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  master passed  |
   | +0 :ok: |  spotbugs  |   2m 54s |  phoenix-core in master has 962 extant spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   7m 31s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 52s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 52s |  the patch passed  |
   | -1 :x: |  checkstyle  |   2m 20s |  phoenix-core: The patch generated 212 new + 4119 unchanged - 71 fixed = 4331 total (was 4190)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch 9 line(s) with tabs.  |
   | +1 :green_heart: |  javadoc  |   0m 44s |  the patch passed  |
   | -1 :x: |  spotbugs  |   3m  4s |  phoenix-core generated 2 new + 960 unchanged - 2 fixed = 962 total (was 962)  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |  97m 32s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate ASF License warnings.  |
   |  |   | 139m 29s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:phoenix-core |
   |  |  org.apache.phoenix.filter.PhoenixPageFilter.getRowKeyAtStop() may expose internal representation by returning PhoenixPageFilter.rowKeyAtStop  At PhoenixPageFilter.java:by returning PhoenixPageFilter.rowKeyAtStop  At PhoenixPageFilter.java:[line 72] |
   |  |  org.apache.phoenix.filter.PhoenixPageFilter.stopImmediatelyForTesting should be package protected  At PhoenixPageFilter.java: At PhoenixPageFilter.java:[line 45] |
   | Failed junit tests | phoenix.end2end.ProductMetricsIT |
   |   | phoenix.end2end.index.GlobalMutableTxIndexIT |
   |   | phoenix.end2end.ReverseScanIT |
   |   | phoenix.end2end.StatsEnabledSplitSystemCatalogIT |
   |   | phoenix.end2end.SortMergeJoinMoreIT |
   |   | phoenix.tx.ParameterizedTransactionIT |
   |   | phoenix.end2end.ViewIT |
   |   | phoenix.end2end.RowValueConstructorIT |
   |   | phoenix.tx.TransactionIT |
   |   | phoenix.end2end.join.HashJoinNoIndexIT |
   |   | phoenix.end2end.DistinctPrefixFilterIT |
   |   | phoenix.end2end.join.HashJoinLocalIndexIT |
   |   | phoenix.end2end.IndexScrutinyToolIT |
   |   | phoenix.end2end.join.SubqueryIT |
   |   | phoenix.end2end.AlterMultiTenantTableWithViewsIT |
   |   | phoenix.end2end.index.PartialIndexRebuilderIT |
   |   | phoenix.end2end.index.GlobalImmutableTxIndexIT |
   |   | phoenix.end2end.join.SortMergeJoinNoSpoolingIT |
   |   | phoenix.end2end.TenantSpecificTablesDDLIT |
   |   | phoenix.end2end.TransactionalViewIT |
   |   | phoenix.tx.TxCheckpointIT |
   |   | phoenix.end2end.index.LocalIndexIT |
   |   | phoenix.end2end.SkipScanQueryIT |
   |   | phoenix.end2end.index.MutableIndexIT |
   |   | phoenix.tx.FlappingTransactionIT |
   |   | phoenix.end2end.join.SortMergeJoinNoIndexIT |
   |   | phoenix.end2end.DerivedTableIT |
   |   | phoenix.end2end.index.MutableIndexFailureIT |
   |   | phoenix.execute.PartialCommitIT |
   |   | phoenix.end2end.index.MutableIndexFailureWithNamespaceIT |
   |   | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT |
   |   | phoenix.end2end.AlterTableWithViewsIT |
   |   | phoenix.end2end.join.HashJoinGlobalIndexIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/phoenix/pull/973 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
   | uname | Linux 9203aaa6937a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 243ac64 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
   | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
   | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
   | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
   |  Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/testReport/ |
   | Max. process+thread count | 6883 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/1/console |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org