[jira] Updated: (THRIFT-857) tests run by "make install" fail if generators are disabled

["Bruce Lowekamp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruce Lowekamp updated THRIFT-857:
----------------------------------

    Attachment: generator-subnamespace.patch

This adds a method to check if a sub-namespace is supported by a generator, called via the generator_factory.  It provides an implementation for the smalltalk generator.  I'm not sure of that implementation.  Looking at t_st_generator, it was referencing smalltalk.prefix and smalltalk.category, whereas t_program.h was referencing prefix and module.  I went with what was in t_st_generator, but I won't claim to have looked at it enough to be sure that's right.

The patch now has the effect that a namespace declaration is rejected if the generator is not present or if the sub-namespace declaration isn't supported by a present generator.

I'm not completely sure I think a warning wouldn't be better if the generator isn't present at all.

Minimally tested, but seems to work.

> tests run by "make install" fail if generators are disabled
> -----------------------------------------------------------
>
>                 Key: THRIFT-857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-857
>             Project: Thrift
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 0.4
>         Environment: mac os
>            Reporter: Bruce Lowekamp
>            Priority: Minor
>         Attachments: generator-subnamespace.patch
>
>
> configuring with generators disabled (configure --disable-gen-java, for example) produces a failed build because the tests run by "make install" require the java, cpp, rb, perl, csharp, and js generators.  
> I would personally favor either removing those --disble-gen options altogether, or adding a warning message in the configure --help output that disabling those generators is not recommended/will cause test failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.