[jira] [Commented] (GIRAPH-997) Upgrade findbugs to 3.0.0

["Maja Kabiljo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14347354#comment-14347354 ] 

Maja Kabiljo commented on GIRAPH-997:
-------------------------------------

Looks good, I'm just wondering about aggregators part now, it means method is not correctly implementing javadoc anymore if it always returns true. cc [~ikabiljo] I assume this was part of your change, don't know if anyone uses the return value of that method, but we should either change it not to return anything or fix it.

> Upgrade findbugs to 3.0.0
> -------------------------
>
>                 Key: GIRAPH-997
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-997
>             Project: Giraph
>          Issue Type: Task
>            Reporter: Dionysios Logothetis
>            Assignee: Dionysios Logothetis
>            Priority: Minor
>              Labels: maven
>         Attachments: GIRAPH-997.patch
>
>
> Finbugs 3.0.0 is necessary to build with Java 8, but it catches the following bugs on mvn -DskipTests -Dcheckstyle.skip=true clean install:
> [INFO] --- findbugs-maven-plugin:3.0.0:check (default) @ giraph-core ---
> [INFO] BugInstance size is 8
> [INFO] Error size is 0
> [INFO] Total bugs: 8
> [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.IntIntTextVertexValueInputFormat$IntIntTextVertexValueReader.preprocessLine(Text) ["org.apache.giraph.io.formats.IntIntTextVertexValueInputFormat$IntIntTextVertexValueReader"] At IntIntTextVertexValueInputFormat.java:[lines 54-71]
> [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.IntNullTextEdgeInputFormat$IntNullTextEdgeReader.preprocessLine(Text) ["org.apache.giraph.io.formats.IntNullTextEdgeInputFormat$IntNullTextEdgeReader"] At IntNullTextEdgeInputFormat.java:[lines 53-76]
> [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader.decodeEdge(String, String) ["org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader"] At LongDoubleDoubleAdjacencyListVertexInputFormat.java:[lines 49-75]
> [INFO] Boxing/unboxing to parse a primitive org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader.decodeId(String) ["org.apache.giraph.io.formats.LongDoubleDoubleAdjacencyListVertexInputFormat$LongDoubleDoubleAdjacencyListVertexReader"] At LongDoubleDoubleAdjacencyListVertexInputFormat.java:[lines 49-75]
> [INFO] Redundant nullcheck of org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class, boolean), which is known to be non-null in org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class) ["org.apache.giraph.master.AggregatorToGlobalCommTranslation"] At AggregatorToGlobalCommTranslation.java:[lines 40-220]
> [INFO] Redundant nullcheck of org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerAggregator(String, Class, boolean), which is known to be non-null in org.apache.giraph.master.AggregatorToGlobalCommTranslation.registerPersistentAggregator(String, Class) ["org.apache.giraph.master.AggregatorToGlobalCommTranslation"] At AggregatorToGlobalCommTranslation.java:[lines 40-220]
> [INFO] org.apache.giraph.zk.ZooKeeperManager.createZooKeeperServerList() invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead ["org.apache.giraph.zk.ZooKeeperManager"] At ZooKeeperManager.java:[lines 60-840]
> [INFO] Inconsistent synchronization of org.apache.giraph.zk.ZooKeeperManager.zkRunner; locked 66% of time ["org.apache.giraph.zk.ZooKeeperManager"] At ZooKeeperManager.java:[lines 60-840]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)