You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/02/20 07:20:41 UTC

[GitHub] [cordova-android] x-and opened a new pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

x-and opened a new pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   unhandled intent:// links with browser_fallback_url param
   
   
   ### Description
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Without yandex map app link open fallback url in browser.
   ```
   D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
   D/CordovaWebViewImpl: showWebPage(https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps, true, false, HashMap)
   ```
   With yandex map app intent open yandexmap
   ```
   D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
   ```
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab edited a comment on pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-803560803


   Thanks for try to improve the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab commented on pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-803560803


   I think this should merged with master version and produce major version to fix any issues related to this.
   
   Thanks for try to improve the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab commented on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-867288450


   > ### Platforms affected
   > Android
   > 
   > ### Motivation and Context
   > unhandled intent:// links with browser_fallback_url param
   > 
   > ### Description
   > ### Testing
   > Without yandex map app link open fallback url in browser.
   > 
   > ```
   > D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
   > D/CordovaWebViewImpl: showWebPage(https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps, true, false, HashMap)
   > ```
   > 
   > With yandex map app intent open yandexmap
   > 
   > ```
   > D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
   > ```
   > 
   > ### Checklist
   > * [ ]  I've run the tests to see all new and existing tests pass
   > * [ ]  I added automated test coverage as appropriate for this change
   > * [ ]  Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   > * [ ]  If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   > * [ ]  I've updated the documentation if necessary
   
   Thanks for PR.
   Can you add this fix to inappbrowser plugin? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab removed a comment on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab removed a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-863766451


   @x-and 
   Any solution for Android InappBrowser ?
   https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu merged pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab removed a comment on pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab removed a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-803560803


   Thanks for try to improve the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io commented on pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-782577915


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=h1) Report
   > Merging [#1167](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=desc) (114569d) into [master](https://codecov.io/gh/apache/cordova-android/commit/a45217e6b94e51c7a3de37448084146e44eeca5a?el=desc) (a45217e) will **increase** coverage by `2.68%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1167/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1167      +/-   ##
   ==========================================
   + Coverage   69.06%   71.74%   +2.68%     
   ==========================================
     Files          20       21       +1     
     Lines        1833     1745      -88     
   ==========================================
   - Hits         1266     1252      -14     
   + Misses        567      493      -74     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <0.00%> (+4.20%)` | :arrow_up: |
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (+10.32%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=footer). Last update [a45217e...114569d](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab edited a comment on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-814459039


   @x-and Hi, thanks for this PR
   Could you please also handle ://intent scheme links for InAppBrowser Plugin?
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab commented on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-863766451


   Any solution for Android InappBrowser ?
   https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab removed a comment on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab removed a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-867288450


   > ### Platforms affected
   > Android
   > 
   > ### Motivation and Context
   > unhandled intent:// links with browser_fallback_url param
   > 
   > ### Description
   > ### Testing
   > Without yandex map app link open fallback url in browser.
   > 
   > ```
   > D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
   > D/CordovaWebViewImpl: showWebPage(https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps, true, false, HashMap)
   > ```
   > 
   > With yandex map app intent open yandexmap
   > 
   > ```
   > D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
   > ```
   > 
   > ### Checklist
   > * [ ]  I've run the tests to see all new and existing tests pass
   > * [ ]  I added automated test coverage as appropriate for this change
   > * [ ]  Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   > * [ ]  If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   > * [ ]  I've updated the documentation if necessary
   
   Thanks for PR.
   Can you add this fix to inappbrowser plugin? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-782577915


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=h1) Report
   > Merging [#1167](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=desc) (114569d) into [master](https://codecov.io/gh/apache/cordova-android/commit/a45217e6b94e51c7a3de37448084146e44eeca5a?el=desc) (a45217e) will **increase** coverage by `2.73%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1167/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1167      +/-   ##
   ==========================================
   + Coverage   69.06%   71.80%   +2.73%     
   ==========================================
     Files          20       21       +1     
     Lines        1833     1745      -88     
   ==========================================
   - Hits         1266     1253      -13     
   + Misses        567      492      -75     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <0.00%> (+4.20%)` | :arrow_up: |
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `70.24% <0.00%> (+10.80%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=footer). Last update [a45217e...114569d](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab commented on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-814459039


   @x-and Hi,
   Could you please also handle ://intent scheme links for InAppBrowser Plugin?
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab removed a comment on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab removed a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-813125983






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab commented on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-813125983


   I think this PR should add additional codes to be more valuable, because some custom scheme names not known, I made some tests with InaAppBrowser Plugin but i still receive this error:
   [net::ERR_UNKNOWN_URL_SCHEME]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] mosabab edited a comment on pull request #1167: feat: handle intent:// scheme links with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-863766451


   @x-and 
   Any solution for Android InappBrowser ?
   https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1167: improve: handle link scheme intent:// with browser_fallback_url param

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1167:
URL: https://github.com/apache/cordova-android/pull/1167#issuecomment-782577915


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=h1) Report
   > Merging [#1167](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=desc) (114569d) into [master](https://codecov.io/gh/apache/cordova-android/commit/a45217e6b94e51c7a3de37448084146e44eeca5a?el=desc) (a45217e) will **increase** coverage by `2.68%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1167/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1167      +/-   ##
   ==========================================
   + Coverage   69.06%   71.74%   +2.68%     
   ==========================================
     Files          20       21       +1     
     Lines        1833     1745      -88     
   ==========================================
   - Hits         1266     1252      -14     
   + Misses        567      493      -74     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <0.00%> (+4.20%)` | :arrow_up: |
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (+10.32%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=footer). Last update [a45217e...114569d](https://codecov.io/gh/apache/cordova-android/pull/1167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org