[GitHub] [lucene-solr] dsmiley commented on a change in pull request #798: LUCENE-8906: Lucene50PostingsFormat.IntBlockTermState becomes public

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #798: LUCENE-8906: Lucene50PostingsFormat.IntBlockTermState becomes public
URL: https://github.com/apache/lucene-solr/pull/798#discussion_r307029580
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsFormat.java
 ##########
 @@ -453,15 +453,15 @@ public FieldsProducer fieldsProducer(SegmentReadState state) throws IOException
     }
   }
   
-  final static class IntBlockTermState extends BlockTermState {
-    long docStartFP = 0;
-    long posStartFP = 0;
-    long payStartFP = 0;
-    long skipOffset = -1;
-    long lastPosBlockOffset = -1;
+  public static final class IntBlockTermState extends BlockTermState {
 
 Review comment:
   I suspect "ant precommit" will not like this as it has no javadocs.  Remember to add the lucene.internal annotation (it extends BlockTermState which is annotated as-such).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org