You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/10/14 15:52:00 UTC

[jira] [Commented] (OPENNLP-1384) Automatically generate document classifications map from model's config.json

    [ https://issues.apache.org/jira/browse/OPENNLP-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775260#comment-17775260 ] 

ASF GitHub Bot commented on OPENNLP-1384:
-----------------------------------------

jzonthemtn opened a new pull request, #553:
URL: https://github.com/apache/opennlp/pull/553

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> Automatically generate document classifications map from model's config.json
> ----------------------------------------------------------------------------
>
>                 Key: OPENNLP-1384
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1384
>             Project: OpenNLP
>          Issue Type: Task
>          Components: Deep Learning
>    Affects Versions: 2.0.0
>            Reporter: Jeff Zemerick
>            Assignee: Jeff Zemerick
>            Priority: Major
>
> Automatically generate classifications map from model's config.json.
> Currently, the implementations utilizing ONNX Runtime require a Map that stores the model-assigned value along with the human readable name for each value. This map must be created manually:
> Map<Integer, String> classifications = new HashMap<>();
> classifications.put(0, "negative");
> classifications.put(1, "positive");
> How to create this map is determined by looking at the model's config.json file. This task is to have OpenNLP read the config.json file and make the map automatically instead of requiring the user to make it manually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)