You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/11/21 02:25:39 UTC

[jira] Created: (HBASE-1999) When HTable goes away, close zk session in shutdown hook or something...

When HTable goes away, close zk session in shutdown hook or something...
------------------------------------------------------------------------

                 Key: HBASE-1999
                 URL: https://issues.apache.org/jira/browse/HBASE-1999
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack


Currently, while there is a close on HTable, it does not let go of the zk session.. it does not call close... because the session is shared by all HTables in the VM.  Add a shutdown hook that will close zk on the way out.   Otherwise it makes for session timeouts in zk server logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-1999) When HTable goes away, close zk session in shutdown hook or something...

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HBASE-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781097#action_12781097 ] 

Jean-Daniel Cryans commented on HBASE-1999:
-------------------------------------------

+1

> When HTable goes away, close zk session in shutdown hook or something...
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1999
>                 URL: https://issues.apache.org/jira/browse/HBASE-1999
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: hcm.patch
>
>
> Currently, while there is a close on HTable, it does not let go of the zk session.. it does not call close... because the session is shared by all HTables in the VM.  Add a shutdown hook that will close zk on the way out.   Otherwise it makes for session timeouts in zk server logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-1999) When HTable goes away, close zk session in shutdown hook or something...

Posted by "stack (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1999:
-------------------------

    Attachment: hcm.patch

This patch seems to do the right thing.  I tried it in a MR context and I see closeSession instead of expiredSession in zk logs when its in place.  Task logs look fine too.

> When HTable goes away, close zk session in shutdown hook or something...
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1999
>                 URL: https://issues.apache.org/jira/browse/HBASE-1999
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>         Attachments: hcm.patch
>
>
> Currently, while there is a close on HTable, it does not let go of the zk session.. it does not call close... because the session is shared by all HTables in the VM.  Add a shutdown hook that will close zk on the way out.   Otherwise it makes for session timeouts in zk server logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HBASE-1999) When HTable goes away, close zk session in shutdown hook or something...

Posted by "stack (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-1999.
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.20.3
     Hadoop Flags: [Reviewed]

Applied branch and trunk (Thanks for review J-D).

> When HTable goes away, close zk session in shutdown hook or something...
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1999
>                 URL: https://issues.apache.org/jira/browse/HBASE-1999
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.3
>
>         Attachments: hcm.patch
>
>
> Currently, while there is a close on HTable, it does not let go of the zk session.. it does not call close... because the session is shared by all HTables in the VM.  Add a shutdown hook that will close zk on the way out.   Otherwise it makes for session timeouts in zk server logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-1999) When HTable goes away, close zk session in shutdown hook or something...

Posted by "stack (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HBASE-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780915#action_12780915 ] 

stack commented on HBASE-1999:
------------------------------

Oh, and I think J-Ds idea of a shutdown hook a good one. 

> When HTable goes away, close zk session in shutdown hook or something...
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1999
>                 URL: https://issues.apache.org/jira/browse/HBASE-1999
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>
> Currently, while there is a close on HTable, it does not let go of the zk session.. it does not call close... because the session is shared by all HTables in the VM.  Add a shutdown hook that will close zk on the way out.   Otherwise it makes for session timeouts in zk server logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-1999) When HTable goes away, close zk session in shutdown hook or something...

Posted by "stack (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HBASE-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780914#action_12780914 ] 

stack commented on HBASE-1999:
------------------------------

This is particular noticeable when the upload is done out of map tasks.  The task creates an HTable and then exits when done, perhaps thousands of times.

The idea to register a shutdown hooks was J-Ds.

> When HTable goes away, close zk session in shutdown hook or something...
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1999
>                 URL: https://issues.apache.org/jira/browse/HBASE-1999
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>
> Currently, while there is a close on HTable, it does not let go of the zk session.. it does not call close... because the session is shared by all HTables in the VM.  Add a shutdown hook that will close zk on the way out.   Otherwise it makes for session timeouts in zk server logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.