You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/05/17 05:29:35 UTC

[GitHub] [incubator-superset] betodealmeida opened a new pull request #7536: Add link to scheduled pipeline

betodealmeida opened a new pull request #7536: Add link to scheduled pipeline
URL: https://github.com/apache/incubator-superset/pull/7536
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR makes it possible to add a link from the scheduled query to the pipeline running it. The user can provide a URL template, that gets formatted with the query to produce a link that takes to the corresponding pipeline (see example in updated docs).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   <img width="960" alt="Screen Shot 2019-05-16 at 10 28 18 PM" src="https://user-images.githubusercontent.com/1534870/57905038-f91e1000-7829-11e9-9123-f115b0d87778.png">
   
   I also added some CSS to remove the disabled `+` button in the form, so it looks better.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Tested locally, and added unit tests for the helper functions.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @khtruong @DiggidyDave @datability-io 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org