You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/23 20:35:39 UTC

[GitHub] [beam] lostluck commented on a diff in pull request #21967: [Go SDK] Go Lint fixes

lostluck commented on code in PR #21967:
URL: https://github.com/apache/beam/pull/21967#discussion_r905440898


##########
sdks/go/pkg/beam/core/runtime/harness/worker_status.go:
##########
@@ -104,7 +104,7 @@ func goroutineDump(statusInfo *strings.Builder) {
 func buildInfo(statusInfo *strings.Builder) {
 	statusInfo.WriteString("\n============Build Info============\n")
 	if info, ok := debug.ReadBuildInfo(); ok {
-		statusInfo.WriteString(info.String())

Review Comment:
   In this case we prioritize the Open Source static check, and not something that only affects Google internal users on code import, where we can ignore them. This will cause the Github Go Tests action to fail for everyone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org