[GitHub] [linkis] casionone commented on a diff in pull request #4373: In ProcessEngineConnLaunch.scala, the parameter log containing spaces…

["casionone (via GitHub)" <gi...@apache.org>]

casionone commented on code in PR #4373:
URL: https://github.com/apache/linkis/pull/4373#discussion_r1139565658


##########
linkis-computation-governance/linkis-engineconn-manager/linkis-engineconn-manager-core/src/main/scala/org/apache/linkis/ecm/core/launch/ProcessEngineConnLaunch.scala:
##########
@@ -151,6 +151,14 @@ trait ProcessEngineConnLaunch extends EngineConnLaunch with Logging {
   def getPid(): Option[String] = None
 
   protected def getCommandArgs: Array[String] = {
+
+    request.creationDesc.properties.asScala.foreach { case (k, v) =>
+      if (k.contains(" ") || (v != null && v.contains(" "))) {
+        logger.info(
+          s"The parameters containing spaces in the startup parameters are(启动参数中包含空格的参数有：${k},Value:${v}"

Review Comment:
   Only the abnormal parameters will be printed one by one,
   The exception information thrown does not bring exception parameters 
   只会一个个打印异常参数，
   抛出的异常信息 没有带上异常参数



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org