You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by lewismc <gi...@git.apache.org> on 2016/05/15 23:11:00 UTC
[GitHub] nutch pull request: NUTCH-2260 JAVA_HOME and hbase-common dependen...
GitHub user lewismc opened a pull request:
https://github.com/apache/nutch/pull/111
NUTCH-2260 JAVA_HOME and hbase-common dependency absent from hbase Docker image
This PR addresses https://issues.apache.org/jira/browse/NUTCH-2260
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/nutch NUTCH-2260
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nutch/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 5622ce18cf30da0c9db79528f295095ebf544d62
Author: Lewis John McGibbney <le...@gmail.com>
Date: 2016-05-15T23:15:04Z
NUTCH-2260 JAVA_HOME and hbase-common dependency absent from hbase Docker image
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: NUTCH-2260 JAVA_HOME and hbase-common dependen...
Posted by bizmate <gi...@git.apache.org>.
Github user bizmate commented on a diff in the pull request:
https://github.com/apache/nutch/pull/111#discussion_r63435076
--- Diff: docker/hbase/Dockerfile ---
@@ -94,7 +94,7 @@ RUN mv /tmp/hadoop-etc/* /opt/hadoop/etc/hadoop
RUN mv /tmp/hbase-etc/* /opt/hbase/conf/
RUN mv /tmp/nutch-etc/* /opt/apache-nutch-2.x/conf/
-ENV JAVA_HOME /usr
+ENV JAVA_HOME /usr/lib/jvm/java-7-oracle
ENV NUTCH_ROOT /opt/apache-nutch-2.x
--- End diff --
To avoid creating another layer could you chain the env variables creation as such?
```
ENV NUTCH_ROOT /opt/apache-nutch-2.x \
JAVA_HOME /usr/lib/jvm/java-7-oracle
```
Thanks for the fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: NUTCH-2260 JAVA_HOME and hbase-common dependen...
Posted by bizmate <gi...@git.apache.org>.
Github user bizmate commented on a diff in the pull request:
https://github.com/apache/nutch/pull/111#discussion_r63303587
--- Diff: docker/hbase/Dockerfile ---
@@ -94,11 +94,13 @@ RUN mv /tmp/hadoop-etc/* /opt/hadoop/etc/hadoop
RUN mv /tmp/hbase-etc/* /opt/hbase/conf/
RUN mv /tmp/nutch-etc/* /opt/apache-nutch-2.x/conf/
-
+ENV JAVA_HOME /usr
--- End diff --
I think JAVA_HOME should be
JAVA_HOME=/usr/lib/jvm/java-7-oracle/
see below
docker exec -it nutch bash -c 'su hduser'
hduser@7f3e7e0c298e:/root$ env | grep JAVA
JAVA_HOME=/usr/lib/jvm/java-7-oracle/
The above was done on purpose on line https://github.com/apache/nutch/blob/2.x/docker/hbase/Dockerfile#L84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nutch pull request: NUTCH-2260 JAVA_HOME and hbase-common dependen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nutch/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---