You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/19 06:41:19 UTC

[GitHub] [incubator-celeborn] nafiyAix opened a new pull request, #982: [DRAFT] Override equals and hashcode for DiskInfo

nafiyAix opened a new pull request, #982:
URL: https://github.com/apache/incubator-celeborn/pull/982

   ### What changes were proposed in this pull request?
   Override equals and hashcode for DiskInfo
   
   ### Why are the changes needed?
   
   
   ### What are the items that need reviewer attention?
   Do we need to remove some unnecessary fields from `hashcode()` and `equals()` ?
   
   ### Related issues.
   None yet
   
   ### Related pull requests.
   
   
   ### How was this patch tested?
   
   
   /cc @AngersZhuuuu 
   
   /assign @main-reviewer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] nafiyAix commented on pull request #982: [DRAFT] Override equals and hashcode for DiskInfo

Posted by GitBox <gi...@apache.org>.
nafiyAix commented on PR #982:
URL: https://github.com/apache/incubator-celeborn/pull/982#issuecomment-1321864329

   > Why need to override this?
   
   Currently we doesn't use DiskInfo as HashMap's key or compare it for equivalence,  but other similar class such as DeviceInfo, WorkerInfo has override them. Shall we only override them when code logic needs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #982: [DRAFT] Override equals and hashcode for DiskInfo

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #982:
URL: https://github.com/apache/incubator-celeborn/pull/982#issuecomment-1321361381

   Why need to override this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] nafiyAix closed pull request #982: [DRAFT] Override equals and hashcode for DiskInfo

Posted by GitBox <gi...@apache.org>.
nafiyAix closed pull request #982: [DRAFT] Override equals and hashcode for DiskInfo
URL: https://github.com/apache/incubator-celeborn/pull/982


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org