You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Lan Ding (Jira)" <ji...@apache.org> on 2023/12/05 03:27:00 UTC

[jira] [Assigned] (KAFKA-15866) Refactor OffsetFetchRequestState Error handling to be more consistent with OffsetCommitRequestState

     [ https://issues.apache.org/jira/browse/KAFKA-15866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lan Ding reassigned KAFKA-15866:
--------------------------------

    Assignee: Lan Ding

> Refactor OffsetFetchRequestState Error handling to be more consistent with OffsetCommitRequestState
> ---------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-15866
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15866
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Philip Nee
>            Assignee: Lan Ding
>            Priority: Minor
>
> The current OffsetFetchRequestState error handling uses nested if-else, which is quite different, stylistically, to the OffsetCommitRequestState using a switch statment.  The latter is a bit more readable so we should refactor the error handling using the same style to improve readability.
>  
> A minor point: Some of the error handling seems inconsistent with the commit. The logic was from the current implementation, so we should also review all the error handling.  For example: somehow the current logic doesn't mark the coordinator unavailable when receiving COORDINATOR_NOT_AVAILABLE



--
This message was sent by Atlassian Jira
(v8.20.10#820010)