[GitHub] sijie commented on a change in pull request #2852: Add connection timeout client configuration option

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #2852: Add connection timeout client configuration option
URL: https://github.com/apache/pulsar/pull/2852#discussion_r229047887
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
 ##########
 @@ -309,4 +309,13 @@ ClientBuilder authentication(String authPluginClassName, Map<String, String> aut
      * @param unit time unit for {@code statsInterval}
      */
     ClientBuilder keepAliveInterval(int keepAliveIntervalSeconds, TimeUnit unit);
+
+    /**
+     * Set the duration of time to wait for a connection to a broker to be established. If the duration
+     * passes without a response from the broker, the connection attempt is dropped.
+     *
+     * @param duration the duration to wait
+     * @param unit the time unit in which the duration is defined
 
 Review comment:
   Can you add `@since` tag? so people will know when this method was added in javadoc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services