You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/01 10:11:00 UTC

[jira] [Commented] (AIRFLOW-4158) Prefix and delimiter support for S3CopyObjectOperator & S3DeleteObjectsOperator

    [ https://issues.apache.org/jira/browse/AIRFLOW-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806606#comment-16806606 ] 

ASF GitHub Bot commented on AIRFLOW-4158:
-----------------------------------------

sherifkk commented on pull request #5018: [AIRFLOW-4158] Prefix and delimiter support for S3CopyObjectOperator & S3DeleteObjectsOperator
URL: https://github.com/apache/airflow/pull/5018
 
 
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4158
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   In S3DeleteObjectsOperator and S3CopyObjectOperator, it only supports the exact key of the file, there is no feature to copy or delete using prefix and delimiter. 
   By this change, we can either use key or prefix and/or delimiter with S3DeleteObjectsOperator and S3CopyObjectOperator, if we use prefix and/or delimiter we can delete/copy all files with the same prefix. It is equivalent to --recursive option of aws command.
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Prefix and delimiter support for S3CopyObjectOperator & S3DeleteObjectsOperator
> -------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4158
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4158
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws, operators
>            Reporter: Mohammed Sherif KK
>            Assignee: Mohammed Sherif KK
>            Priority: Major
>              Labels: feature
>
> In S3DeleteObjectsOperator and S3CopyObjectOperator, it only supports the exact key of the file, there is no feature to copy or delete using prefix and delimiter. 
> By this change, we can either use key or prefix and/or delimiter with S3DeleteObjectsOperator and S3CopyObjectOperator, if we use prefix and/or delimiter we can delete/copy all files with the same prefix. It is equivalent to --recursive option of aws command.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)