You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ek...@apache.org on 2015/09/11 14:56:27 UTC

[3/5] git commit: updated refs/heads/master to a04b8f6

Merge pull request #805 from ekholabs/improvement/callable_CLOUDSTACK-8822

CLOUDSTACK-8822 - Replacing Runnable by CallableThat's the first part of the refactor, which will touch the ManagedContextRunnable and all its subclasses. However, in order to reduce impact, the first part comprises the Agent and Nio related classes (NioConnection, NioServer and NioClient).

* All the sub-classes were also updated according to the changes in the super-classes
* Improved exception handling
* There were also code formatting changes

Changes were structural and the NioTest covered them without need to modify the unit test.

This PR is quite extensive. Please, wait for the Test Report in order to proceed with further review.

ping @remibergsma @miguelaferreira @bhaisaab @karuturi @wido @DaanHoogland @borisroman @K0zka

Cheers,
Wilder

* pr/805:
  CLOUDSTACK-8822 - Replacing Runnable by Callable in the Taks and NioConnection classes

Signed-off-by: wilderrodrigues <wr...@schubergphilis.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/68bf0491
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/68bf0491
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/68bf0491

Branch: refs/heads/master
Commit: 68bf049106959a13f74d42b07366da6e033e3446
Parents: ba59a43 79a3f8c
Author: wilderrodrigues <wr...@schubergphilis.com>
Authored: Fri Sep 11 14:52:35 2015 +0200
Committer: wilderrodrigues <wr...@schubergphilis.com>
Committed: Fri Sep 11 14:52:36 2015 +0200

----------------------------------------------------------------------
 agent/src/com/cloud/agent/Agent.java            | 125 ++++---
 .../cloud/agent/manager/AgentManagerImpl.java   |  18 +-
 .../manager/ClusteredAgentManagerImpl.java      | 363 ++++++++++---------
 .../java/com/cloud/utils/SerialVersionUID.java  |   2 +
 .../utils/exception/NioConnectionException.java |  48 +++
 .../utils/exception/TaskExecutionException.java |  48 +++
 .../java/com/cloud/utils/nio/NioClient.java     |  32 +-
 .../java/com/cloud/utils/nio/NioConnection.java | 304 +++++++++-------
 .../java/com/cloud/utils/nio/NioServer.java     |  10 +-
 .../src/main/java/com/cloud/utils/nio/Task.java |  25 +-
 .../java/com/cloud/utils/testcase/NioTest.java  |  35 +-
 11 files changed, 582 insertions(+), 428 deletions(-)
----------------------------------------------------------------------