[jira] [Commented] (KAFKA-3817) KTableRepartitionMap should handle null inputs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366589#comment-15366589 ] 

ASF GitHub Bot commented on KAFKA-3817:
---------------------------------------

GitHub user guozhangwang opened a pull request:

    https://github.com/apache/kafka/pull/1597

    KAFKA-3817 Follow-up: Avoid forwarding old value if it is null in KTableRepartition

    Also handle Null value in SmokeTestUtil.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guozhangwang/kafka KHotfix-check-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1597
    
----
commit 1b73da4110be9c233e7f20ea306a51b1448cbfa4
Author: Guozhang Wang <wa...@gmail.com>
Date:   2016-07-07T18:50:44Z

    Do not forward old value if it is null in KTableRepartition; also handle Null value in SmokeTestUtil

----


> KTableRepartitionMap should handle null inputs
> ----------------------------------------------
>
>                 Key: KAFKA-3817
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3817
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.0.0
>            Reporter: Jeff Klukas
>            Assignee: Guozhang Wang
>             Fix For: 0.10.0.1
>
>
> When calling {{KTable.groupBy}} on the result of a KTable-KTable join, NPEs are raised:
> {{org.apache.kafka.streams.kstream.internals.KTableRepartitionMap$
> > KTableMapProcessor.process(KTableRepartitionMap.java:88)}}
> The root cause is that the join is expected to emit null values when no match is found, but KTableRepartitionMap is not set up to handle this case.
> On the users email list, [~guozhang] described a plan of action:
> I think this is actually a bug in KTableRepartitionMap
> that it actually should expect null grouped keys; this would be a
> straight-forward fix for this operator, but I can make a pass over all the
> repartition operators just to make sure they are all gracefully handling
> null keys.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)